rfv(?): 5.4 ucd-snmp/memory: memTotalFree

This is a multi-part message in MIME format.
--------------020504030509020305050607
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

-Coders,

ucd-snmp/memory in 5.4 uses the mem HAL and has (in
agent/mibgroup/ucd-snmp/memory.c):

case MEMORY_FREE:
/* XXX - or NS_MEM_TYPE_VIRTMEM */
mem_info = netsnmp_memory_get_byIdx( NETSNMP_MEM_TYPE_PHYSMEM, 0 );
if (!mem_info)
goto NOSUCH;
val = mem_info->free; /* memfree + swapfree */

So it currently gives free *physical* memory for UCD-SNMP-MIB::memTotalFree
while 5.3.x (at least on Linux where I've checked) adds free swap as the comment
implies. Is this an intended change in behaviour? If not, please vote on the
attached patch for 5.4, please.


+Thomas

--
Thomas Anders (thomas.anders at blue-cable.de)

--------------020504030509020305050607
Content-Type: text/x-patch;
name="memTotalFree.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="memTotalFree.diff"

Index: agent/mibgroup/ucd-snmp/memory.c
================================================== =================
RCS file: /cvsroot/net-snmp/net-snmp/agent/mibgroup/ucd-snmp/memory.c,v
retrieving revision 5.16
diff -u -r5.16 memory.c
--- agent/mibgroup/ucd-snmp/memory.c 25 Aug 2006 11:38:59 -0000 5.16
+++ agent/mibgroup/ucd-snmp/memory.c 27 Oct 2006 22:53:49 -0000
@@ -140,8 +140,7 @@
val *= (mem_info->units/1024);
break;
case MEMORY_FREE:
- /* XXX - or NS_MEM_TYPE_VIRTMEM */
- mem_info = netsnmp_memory_get_byIdx( NETSNMP_MEM_TYPE_PHYSMEM, 0 );
+ mem_info = netsnmp_memory_get_byIdx( NETSNMP_MEM_TYPE_VIRTMEM, 0 );
if (!mem_info)
goto NOSUCH;
val = mem_info->free; /* memfree + swapfree */

--------------020504030509020305050607
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=...057&dat=121642
--------------020504030509020305050607
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/...et-snmp-coders

--------------020504030509020305050607--