Re: how to test the performance of modified openssh

Chris Rapier wrote:
>
>> Chris: make sure you have clientloop.c rev 1.171. There's a latent
>> bug that sets the max packet size to nonsensically large values for
>> remote port forwards, which may or may not be affecting you.
>
> Just a quick question, the version shipped with 4.7 is 1.181. 1.171
> seems to be around 1.5 years old. Version 1.185 says it corrects overly
> large maximum packet sizes. Should I downgrade to 1.171 or go up to 1.185?

Ah, I see the discrepancy: it's Portable's 1.171 but it's OpenBSD's
1.185 (the latter is what you'll see in the $OpenBSD tag at the start of
the file). Specifically, you want this change:

diff -u -p -r1.170 -r1.171
--- clientloop.c 28 Dec 2007 15:45:07 -0000 1.170
+++ clientloop.c 28 Dec 2007 22:37:10 -0000 1.171
@@ -1,4 +1,4 @@
-/* $OpenBSD: clientloop.c,v 1.184 2007/12/28 15:32:24 dtucker Exp $ */
+/* $OpenBSD: clientloop.c,v 1.185 2007/12/28 22:34:47 dtucker Exp $ */
/*
* Author: Tatu Ylonen <ylo@cs.hut.fi>
* Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
@@ -1745,7 +1745,7 @@ client_request_forwarded_tcpip(const cha
}
c = channel_new("forwarded-tcpip",
SSH_CHANNEL_CONNECTING, sock, sock, -1,
- CHAN_TCP_WINDOW_DEFAULT, CHAN_TCP_WINDOW_DEFAULT, 0,
+ CHAN_TCP_WINDOW_DEFAULT, CHAN_TCP_PACKET_DEFAULT, 0,
originator_address, 1);
xfree(originator_address);
xfree(listen_address);
@@ -1803,7 +1803,7 @@ client_request_agent(const char *request
return NULL;
c = channel_new("authentication agent connection",
SSH_CHANNEL_OPEN, sock, sock, -1,
- CHAN_X11_WINDOW_DEFAULT, CHAN_TCP_WINDOW_DEFAULT, 0,
+ CHAN_X11_WINDOW_DEFAULT, CHAN_TCP_PACKET_DEFAULT, 0,
"authentication agent connection", 1);
c->force_drain = 1;
return c;


--
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4 37C9 C982 80C7 8FF4 FA69
Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/li...enssh-unix-dev