Re: NULL ptr dereferences found with Calysto static checker

Hi,

On 6/21/07, Gert Doering <gert@greenie.muc.de> wrote:
> "The return value is the null pointer if time cannot be represented as a
> broken-down time; typically this is because the year cannot fit into an int."
>
> - so, OpenSSH will break in the year 4294967297. Damn.

It says 'typically', so, there are probably also other conditions under which
that can happen. One way or another, it shouldn't be dereferenced directly
without checking. Most high-quality open source projects I've analyzed so
far check the result of localtime/gmtime. However, if community strongly
feels that this should not be reported as a bug, it's really trivial to tell
that to Calysto.

Regards,

--
Domagoj Babic

http://www.domagoj.info/
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
http://lists.mindrot.org/mailman/lis...enssh-unix-dev