Re: [PATCH 8/12] openssh-4.3p2 return code check bugs

On Tue, 2006-05-16 at 16:46 +0200, Markus Friedl wrote:
> On Mon, May 15, 2006 at 03:19:17PM -0500, Kylene Jo Hall wrote:
> > The get_handle function can return a negative value. The variable that
> > value is assigned to is eventually passed to handle_close which uses the
> > value as an array index thus not being able to handle negative values.
> > This patch adds the return code check and provides an appropriate error
> > exit in the event of a negative return code. This entire set of patches
> > passed the regression tests on my system. Bugs found by Coverity.
>
> i'm not sure about this one. we always call handle_is_ok()
> after get_handle(), so an error is sent back in any case.

In the instances in this patch I don't see handle_is_ok being called.
Is it called by some intermediate function that I didn't think to look
in. Maybe adding handle_is_ok is the appropriate fix here instead of
the way I dealt with it.

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
http://www.mindrot.org/mailman/listi...enssh-unix-dev