Re: [PATCH 8/12] openssh-4.3p2 return code check bugs

On Mon, May 15, 2006 at 03:19:17PM -0500, Kylene Jo Hall wrote:
> The get_handle function can return a negative value. The variable that
> value is assigned to is eventually passed to handle_close which uses the
> value as an array index thus not being able to handle negative values.
> This patch adds the return code check and provides an appropriate error
> exit in the event of a negative return code. This entire set of patches
> passed the regression tests on my system. Bugs found by Coverity.

i'm not sure about this one. we always call handle_is_ok()
after get_handle(), so an error is sent back in any case.

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
http://www.mindrot.org/mailman/listi...enssh-unix-dev