[PATCH 10/12 bugfix: openssh-4.3p2: memory leak

This is a discussion on [PATCH 10/12 bugfix: openssh-4.3p2: memory leak within the OpenSSH Development forums, part of the Networking and Network Related category; The variable local_user was allocated by xstrdup and is not freed or pointed to in this branch. This patch adds ...


Go Back   Usenet Forums > Networking and Network Related > OpenSSH Development

FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #1 (permalink)  
Old 05-16-2006
Kylene Jo Hall
 
Posts: n/a
Default [PATCH 10/12 bugfix: openssh-4.3p2: memory leak

The variable local_user was allocated by xstrdup and is not freed or
pointed to in this branch. This patch adds the xfree. This entire set
of patches passed the regression tests on my system. Bug found by
Coverity.
Signed-off-by: Kylene Hall <kjhall@us.ibm.com>
---
sshconnect.c | 1 +
1 files changed, 1 insertion(+)

diff -uprN openssh-4.3p2/sshconnect.c openssh-4.3p2-kylie/sshconnect.c
--- openssh-4.3p2/sshconnect.c 2005-12-13 02:29:03.000000000 -0600
+++ openssh-4.3p2-kylie/sshconnect.c 2006-05-04 10:07:57.000000000 -0500
@@ -937,6 +937,7 @@ ssh_login(Sensitive *sensitive, const ch
} else {
ssh_kex(host, hostaddr);
ssh_userauth1(local_user, server_user, host, sensitive);
+ xfree(local_user);
}
}



_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
http://www.mindrot.org/mailman/listi...enssh-unix-dev
Reply With Quote
Reply
Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are Off
[IMG] code is Off
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On



All times are GMT +1. The time now is 09:18 AM.


Powered by vBulletin® Version 3.7.3
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO 3.0.0