Re: parameter value overflow in main.cf

On 2004-02-03 14:56, Victor.Duchovni@morganstanley.com wrote:
>>I noticed that postfix doesn't say a word if value of integer parameter
>>in main.cf is too big. The int variable is silently overflowed.

> Known issue, and providing sensible inputs in *configuration* files is the
> administrator's responsibility. Postfix is careful when processing data
> received from untrusted sources, but the administrator is expected to not
> screw up.

nice assumption :)

>>It seems that
>>static int convert_mail_conf_int(const char *name, int *intval)
>>should be rewritten to check for overflows (possibly use
>>strtoll instead of sscanf etc.)
>
> strtoll() is not available on some platforms supported by Postfix. Fixing
> this requires Postfix to use its own conversion functions or, to convert
> the value back to a string and compare the strings. It is apparent that
> the effort is justified in this case.

I looked at the code and I think that it would be pretty nice to
add mail_conf_size.c (we already have bool, int, raw, str and time).
It would accept k, m and g as units.
I would also add overflow check there.

It would require changes in many places to switch from int to size
but it can be done later.

What do you think about it?

regards
--
Marcin Gryszkalis
jabber jid:mg@chrome.pl
gg:2532994
http://fork.pl